Re: [PATCH 5/5 gnumach] linux: Skip probing IDE when 255 phys heads detected

[Almudena Garcia]

It's great!!

If I remember well, this caused me some problems when I tried to install Debian GNU/Hurd with SATA over real hardware a year ago.

El mié, 1 feb 2023 a las 11:56, Damien Zammit (<damien@zamaudio.com>) escribió:

This allows qemu -M q35 to boot without 30 second timeout
failing on hd0, when disk is actually attached via ahci.

I very much doubt a disk exists with 255 physical heads.
---
 linux/src/drivers/block/ide.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux/src/drivers/block/ide.c b/linux/src/drivers/block/ide.c
index 2d0fc77e..41d4cef8 100644
--- a/linux/src/drivers/block/ide.c
+++ b/linux/src/drivers/block/ide.c
@@ -2964,7 +2964,7 @@ static void probe_cmos_for_drives (ide_hwif_t *hwif)
                        unsigned char  head = *(BIOS+2);
                        unsigned char  sect = *(BIOS+14);
                        unsigned char  ctl  = *(BIOS+8);
-                       if (cyl > 0 && head > 0 && sect > 0 && sect < 64) {
+                       if (cyl > 0 && head > 0 && sect > 0 && sect < 64 && head != 0xff) {
                                drive->cyl   = drive->bios_cyl  = cyl;
                                drive->head  = drive->bios_head = head;
                                drive->sect  = drive->bios_sect = sect;
--
2.34.1