Re: [PATCH 2/2] add rpc_versions for vm types

[Samuel Thibault]

Samuel Thibault, le lun. 29 août 2022 01:21:23 +0200, a ecrit:
> Hello,
> 
> Luca Dariz, le dim. 03 avril 2022 16:59:55 +0200, a ecrit:
> > @@ -88,13 +94,36 @@ typedef unsigned long long rpc_phys_addr_t;
> >   * expressing the difference between two
> >   * vm_offset_t entities.
> >   */
> > -#ifdef __x86_64__
> >  typedef    unsigned long   vm_size_t;
> > -#else
> > -typedef    natural_t       vm_size_t;
> > -#endif
> >  typedef    vm_size_t *     vm_size_array_t;
> 
> Mmm, this has triggered a lot of warnings & errors about mismatches
> between vm_size_t and mach_msg_type_number_t in userland hurd&glibc.

Do we really need to make vm_size_t always unsigned long? In gcc&glibc,
they are unsigned, and thus size_t and vm_size_t would be incompatible,
that's a bit odd. Also, it prevents from using %zd to print vm_size_t
without getting a warning.

Samuel