[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/6] fix console setting from cmdline
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 4/6] fix console setting from cmdline |
Date: |
Fri, 28 Jan 2022 20:59:43 +0100 |
User-agent: |
NeoMutt/20170609 (1.8.3) |
Luca Dariz, le ven. 28 janv. 2022 19:24:07 +0100, a ecrit:
> The leading space prevents it working if console=comX is the only
> argument.
But it would be confused with another parameter which would be
foobarconsole=bla
You'd probably want to make the code also try strncmp(kernel_cmdline,
CONSOLE_PARAMETER+1)
Samuel
> Signed-off-by: Luca Dariz <luca@orpolo.org>
> ---
> i386/i386at/com.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/i386/i386at/com.c b/i386/i386at/com.c
> index 3402a025..d1de51c0 100644
> --- a/i386/i386at/com.c
> +++ b/i386/i386at/com.c
> @@ -183,7 +183,7 @@ comcnprobe(struct consdev *cp)
> struct bus_device *b;
> int maj, unit, pri;
>
> -#define CONSOLE_PARAMETER " console=com"
> +#define CONSOLE_PARAMETER "console=com"
> u_char *console = (u_char *) strstr(kernel_cmdline, CONSOLE_PARAMETER);
>
> if (console)
> --
> 2.30.2
>
>
- [PATCH 0/6] Add initial support for booting x86_64 from grub, Luca Dariz, 2022/01/28
- [PATCH 4/6] fix console setting from cmdline, Luca Dariz, 2022/01/28
- Re: [PATCH 4/6] fix console setting from cmdline,
Samuel Thibault <=
- [PATCH 3/6] fix register corruption in irq on qemu, Luca Dariz, 2022/01/28
- [PATCH 2/6] cleanup multiboot, Luca Dariz, 2022/01/28
- [PATCH 1/6] add support for booting from grub with x86_64, Luca Dariz, 2022/01/28
- [PATCH 6/6] fix Task State Segment layout for 64 bit, Luca Dariz, 2022/01/28
- [PATCH 5/6] enable user access, Luca Dariz, 2022/01/28