bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pci-arbiter: Stop using deprecated region memory pointer


From: Joan Lledó
Subject: Re: [PATCH] pci-arbiter: Stop using deprecated region memory pointer
Date: Fri, 7 Jan 2022 12:09:55 +0100

Hi,

> Rather >= ?

No, libpciaccess accepts using the legacy method for addrress up to 0x100000 
included.

> Also, why this address?  Putting a comment there would be welcome to explain 
> the magic number.

I'm taking the condition from here:

https://gitlab.freedesktop.org/xorg/lib/libpciaccess/-/blob/master/src/common_interface.c#L677

I updated the patch to add a comment, and also updated the condition to match 
the one in libpciaccess, including not only the base address but also the size





reply via email to

[Prev in Thread] Current Thread [Next in Thread]