[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libmachdev: Install as translator when bootstrapping && fix

From: Damien Zammit
Subject: Re: [PATCH] libmachdev: Install as translator when bootstrapping && fix rumpdisk injection
Date: Sun, 15 Nov 2020 11:26:03 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 14/11/20 8:17 pm, Samuel Thibault wrote:
> Hello,
> Damien Zammit, le sam. 14 nov. 2020 14:37:37 +1100, a ecrit:
>> Previous problems mentioned with 2x rumpdisk partitions all fixed.
> Congrats!
> What was the issue?

The logic around default behaviour when the device was already open was
broken, causing D_ALREADY_OPEN from being returned I think gave EBUSY
but the send right was still being set?  I'm not exactly sure,
but after I fixed the device_open logic it worked correctly.

By the way, should we keep the device right stored in struct block_device *bd,
so we can give already open devices the same right? Or is it okay to continue
calling ports_get_right(bd) every time we reopen?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]