[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] - hurd pci-arbiter: remove embedded pciaccess code
From: |
Damien Zammit |
Subject: |
Re: [PATCH] - hurd pci-arbiter: remove embedded pciaccess code |
Date: |
Sun, 11 Nov 2018 12:49:29 +1100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 10/11/18 20:42, Samuel Thibault wrote:
> Damien Zammit, le sam. 10 nov. 2018 18:58:35 +1100, a ecrit:
>> +CPPFLAGS += -imacros $(srcdir)/config.h
>
> Why is this needed?
I have now removed config.h and this line.
> So it seems that libpciaccess doesn't provide an interface for this.
> Please leave as TODO in config_block_op to just return what could be
> read once op() returns EIO, so that we do get the short reads
> implemented by just leaving it up to libpciaccess. Limiting to 256 bytes
> will be fine for now.
I added this in the TODO file
>> @@ -85,7 +85,7 @@ S_pci_conf_read (struct protid * master, int reg, char
>> **data,
>> -
>> +
> Please avoid such unneeded hunk :)
Fixed
>> @@ -266,7 +276,7 @@ create_fs_tree (struct pcifs * fs, struct pci_system *
>> pci_sys)
>> - e_stat.st_size = device->config_size;
>> + e_stat.st_size = PCI_CONFIG_SIZE; // FIXME: Hardcoded
> Mmm. This will also be a TODO. I'd say on the long run libpciaccess
> should really provide a way to get the config size instead of having to
> just get EIO.
Yes, it would be nice if libpciaccess provided the size of the config
space. I have just left this as is for now.
See attached for revised patch.
Damien
0001-hurd-pci-arbiter-Remove-embedded-pciaccess-code.patch
Description: Text Data