[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] libports: unlock _ports_lock on malloc failure
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 1/2] libports: unlock _ports_lock on malloc failure |
Date: |
Mon, 5 May 2014 17:35:13 +0200 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Mon 05 May 2014 17:33:11 +0200, a écrit :
> * libports/bucket-iterate.c (_ports_bucket_class_iterate): Unlock
> _ports_lock on malloc failure.
Ack.
> ---
> libports/bucket-iterate.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/libports/bucket-iterate.c b/libports/bucket-iterate.c
> index 498cf13..babc204 100644
> --- a/libports/bucket-iterate.c
> +++ b/libports/bucket-iterate.c
> @@ -46,7 +46,10 @@ _ports_bucket_class_iterate (struct port_bucket *bucket,
> nr_items = bucket->htable.nr_items;
> p = malloc (nr_items * sizeof *p);
> if (p == NULL)
> - return ENOMEM;
> + {
> + pthread_mutex_unlock (&_ports_lock);
> + return ENOMEM;
> + }
>
> n = 0;
> HURD_IHASH_ITERATE (&bucket->htable, arg)
> --
> 2.0.0.rc0
>
--
Samuel
j'etais en train de nettoyer ma souris et le coup est parti...
-+- s sur #ens-mim - et en plus c vrai... -+-