[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/9] exec: abbreviate the task name if necessary
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 4/9] exec: abbreviate the task name if necessary |
Date: |
Mon, 28 Apr 2014 12:32:31 +0200 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Mon 28 Apr 2014 12:19:59 +0200, a écrit :
> * exec/exec.c (do_exec): If the formatted task name exceeds
> TASK_NAME_SIZE, abbreviate it.
Ack.
> ---
> exec/exec.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/exec/exec.c b/exec/exec.c
> index 935762e..b068f5e 100644
> --- a/exec/exec.c
> +++ b/exec/exec.c
> @@ -1168,9 +1168,20 @@ do_exec (file_t file,
> goto out;
>
> char *name;
> - if (asprintf (&name, "%s(%d)", argv, pid) > 0)
> + int size = asprintf (&name, "%s(%d)", argv, pid);
> + if (size > 0)
> {
> - task_set_name (newtask, name);
> +/* This is an internal implementational detail of the gnumach kernel. */
> +#define TASK_NAME_SIZE 32
> + if (size < TASK_NAME_SIZE)
> + task_set_name (newtask, name);
> + else
> + {
> + char *abbr = name + size - TASK_NAME_SIZE + 1;
> + abbr[0] = abbr[1] = abbr[2] = '.';
> + task_set_name (newtask, abbr);
> + }
> +#undef TASK_NAME_SIZE
> free (name);
> }
> }
> --
> 1.9.2
>
--
Samuel
<y> le y est un animal discret se logeant facilement dans un terminal
*** c has changed the topic on channel #ens-mim to ne pas jeter de cacahuetes
aux ys, svp
-+- #ens-mim - n'oubliez pas le guide -+-
- let's make libpager single-threaded, Justus Winter, 2014/04/28
- [PATCH 4/9] exec: abbreviate the task name if necessary, Justus Winter, 2014/04/28
- Re: [PATCH 4/9] exec: abbreviate the task name if necessary,
Samuel Thibault <=
- [PATCH 5/9] ext2fs: fix type of inum, Justus Winter, 2014/04/28
- [PATCH 7/9] ext2fs: use two distinct pager buckets for the disk and file pager, Justus Winter, 2014/04/28
- [PATCH 9/9] libpager: remove all the unused seqno parameters, Justus Winter, 2014/04/28
- [PATCH 6/9] ext2fs: simplify expression, Justus Winter, 2014/04/28
- [PATCH 8/9] libpager: make libpager single-threaded, Justus Winter, 2014/04/28
- Re: let's make libpager single-threaded, Richard Braun, 2014/04/28