[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/8] mach-defpager: fix warnings about uninitialized variable
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 6/8] mach-defpager: fix warnings about uninitialized variables |
Date: |
Thu, 13 Mar 2014 00:06:43 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Wed 12 Mar 2014 15:55:52 +0100, a écrit :
> * mach-defpager/default_pager.c (S_default_pager_objects): Initialize
> address, size-pairs to 0.
> (S_default_pager_object_pages): Likewise.
> * mach-defpager/kalloc.c (kget_space): Likewise.
Ack.
> ---
> mach-defpager/default_pager.c | 12 ++++++------
> mach-defpager/kalloc.c | 2 +-
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/mach-defpager/default_pager.c b/mach-defpager/default_pager.c
> index 1b9d511..4127126 100644
> --- a/mach-defpager/default_pager.c
> +++ b/mach-defpager/default_pager.c
> @@ -3423,13 +3423,13 @@ S_default_pager_objects (mach_port_t pager,
> mach_port_array_t *portsp,
> natural_t *pcountp)
> {
> - vm_offset_t oaddr; /* memory for objects */
> - vm_size_t osize; /* current size */
> + vm_offset_t oaddr = 0; /* memory for objects */
> + vm_size_t osize = 0; /* current size */
> default_pager_object_t *objects;
> natural_t opotential;
>
> - vm_offset_t paddr; /* memory for ports */
> - vm_size_t psize; /* current size */
> + vm_offset_t paddr = 0; /* memory for ports */
> + vm_size_t psize = 0; /* current size */
> mach_port_t *ports;
> natural_t ppotential;
>
> @@ -3657,8 +3657,8 @@ S_default_pager_object_pages (mach_port_t pager,
> default_pager_page_array_t *pagesp,
> natural_t *countp)
> {
> - vm_offset_t addr; /* memory for page offsets */
> - vm_size_t size; /* current memory size */
> + vm_offset_t addr = 0; /* memory for page offsets */
> + vm_size_t size = 0; /* current memory size */
> default_pager_page_t *pages;
> natural_t potential, actual;
> kern_return_t kr;
> diff --git a/mach-defpager/kalloc.c b/mach-defpager/kalloc.c
> index 777cd3d..2f8f002 100644
> --- a/mach-defpager/kalloc.c
> +++ b/mach-defpager/kalloc.c
> @@ -122,7 +122,7 @@ void kalloc_init(void)
> */
> vm_offset_t kget_space(vm_offset_t size)
> {
> - vm_size_t space_to_add;
> + vm_size_t space_to_add = 0;
> vm_offset_t new_space = 0;
> vm_offset_t addr;
>
> --
> 1.9.0
>
--
Samuel
After watching my newly-retired dad spend two weeks learning how to make a new
folder, it became obvious that "intuitive" mostly means "what the writer or
speaker of intuitive likes".
(Bruce Ediger, bediger@teal.csn.org, in comp.os.linux.misc, on X the
intuitiveness of a Mac interface.)
- Re: [PATCH 3/8] mach-defpager: add and use synchronized_printf for dprintf, (continued)
- [PATCH 4/8] mach-defpager: fix error handling in S_default_pager_object_set_size, Justus Winter, 2014/03/12
- [PATCH 5/8] mach-defpager: fix warning about uninitialized variable, Justus Winter, 2014/03/12
- [PATCH 2/8] mach-defpager: fix warnings about unused variables, Justus Winter, 2014/03/12
- [PATCH 8/8] mach-defpager: silently ignore requests to page to active partition, Justus Winter, 2014/03/12
- [PATCH 6/8] mach-defpager: fix warnings about uninitialized variables, Justus Winter, 2014/03/12
- Re: [PATCH 6/8] mach-defpager: fix warnings about uninitialized variables,
Samuel Thibault <=
- [PATCH 7/8] mach-defpager: fix type of size arguments, Justus Winter, 2014/03/12
- Re: [PATCH 1/8] mach-defpager: remove comments around form feeds, Samuel Thibault, 2014/03/12