Re: exec server and /dev/fd/N

[Carl Fredrik Hammar]

Hi,

On Tue, May 25, 2010 at 11:03:43PM +0200, Emilio Pozuelo Monfort wrote:
> > The first three patches are pretty useless on their own, they all affect
> > the same program, and most changes are pretty mechanical, so I think
> > you might as well merge them.
> 
> OK. I thought about going step by step to not end with one single huge patch,
> but maybe that was too much ;)

It could be worth it if the changes are more complex.

> > Are you familiar with TopGit?  It is pretty useful when developing
> > patch series since you can keep history of the development of a patch.
> > It is also nice since it helps you maintain the ChangeLog if you keep
> > it in .topmsg, which will later become the commit message for the patch.
> 
> I've never used it. I'm familiar with quilt, which has no history but maybe 
> its
> usage is somewhat similar? (I once saw a comparison between git, topgit and 
> quilt)

I'm not sure since I haven't used quilt when developing patches.  The
basic idea is that you have one (almost regular) git branch per patch.
TopGit then maintains the dependencies between the branches, so that
when you change one branch you can update a branch that depends on it
by just checking it out and do a `tg update', which is very convenient.
TopGit is still a bit immature but it works.

Thomas is going to use it to maintain glibc patches in its Savannah repo.
(Actually, I've been meaning to check out how this project is coming along.)

> > Now to the details.  I've commented on every hunk to make sure I looked
> > through it all, which makes it a bit long but hopefully easy to follow
> > (complain if it isn't).
> 
> I think that's perfect.
> 
> All your comments look fine and I'll address the problems in the next patch.

OK, looking forward to it.  :-)

Regards,
  Fredrik