[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: The patch of glibc which allows the user to override the pfinet serv
From: |
olafBuddenhagen |
Subject: |
Re: The patch of glibc which allows the user to override the pfinet server |
Date: |
Fri, 22 Aug 2008 02:12:38 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hi,
On Tue, Aug 19, 2008 at 03:27:06PM +0200, zhengda wrote:
> - socket_t server;
> + socket_t server = MACH_PORT_NULL;
As I already said, this is unnecessary -- it will be assigned
unconditionally.
> + if (__asprintf (&name, "%s/%d", sock_servs, domain) < 0)
> + goto out;
Indentation seems wrong here.
(I hope this is not another tab confusion or something, but I don't
think so...)
> if (domain <= max_domain)
> - servers[domain] = server;
> + servers[domain] = server;
I'm not sure about this, but I think it is usually better to avoid
changing the indentation of code you haven't otherwise touched -- even
if it was wrong before...
Aside from that, the patch looks fine to me :-)
-antrik-
- Re: The patch of glibc which allows the user to override the pfinet server, (continued)
- Re: The patch of glibc which allows the user to override the pfinet server, olafBuddenhagen, 2008/08/14
- Re: The patch of glibc which allows the user to override the pfinet server, zhengda, 2008/08/15
- Re: The patch of glibc which allows the user to override the pfinet server, Samuel Thibault, 2008/08/15
- Re: The patch of glibc which allows the user to override the pfinet server, zhengda, 2008/08/15
- Re: The patch of glibc which allows the user to override the pfinet server, Samuel Thibault, 2008/08/15
- Re: The patch of glibc which allows the user to override the pfinet server, zhengda, 2008/08/15
- Re: The patch of glibc which allows the user to override the pfinet server, Samuel Thibault, 2008/08/15
- Re: The patch of glibc which allows the user to override the pfinet server, zhengda, 2008/08/17
- Re: The patch of glibc which allows the user to override the pfinet server, Samuel Thibault, 2008/08/17
- Re: The patch of glibc which allows the user to override the pfinet server, zhengda, 2008/08/19
- Re: The patch of glibc which allows the user to override the pfinet server,
olafBuddenhagen <=
- Re: The patch of glibc which allows the user to override the pfinet server, Da Zheng, 2008/08/22
- Re: The patch of glibc which allows the user to override the pfinet server, olafBuddenhagen, 2008/08/25
- Re: The patch of glibc which allows the user to override the pfinet server, Samuel Thibault, 2008/08/26
- Re: The patch of glibc which allows the user to override the pfinet server, Da Zheng, 2008/08/26
- Re: The patch of glibc which allows the user to override the pfinet server, olafBuddenhagen, 2008/08/16
- Re: The patch of glibc which allows the user to override the pfinet server, zhengda, 2008/08/17
- Re: The patch of glibc which allows the user to override the pfinet server, Samuel Thibault, 2008/08/17
- Re: The patch of glibc which allows the user to override the pfinet server, olafBuddenhagen, 2008/08/18