|
From: | zhengda |
Subject: | Re: The patch of boot to open a virtual network interface |
Date: | Thu, 21 Aug 2008 10:43:03 +0200 |
User-agent: | Thunderbird 2.0.0.16 (X11/20080707) |
Ben Asselstine wrote:
On Tue, Aug 19, 2008 at 4:02 PM, zhengda <zhengda1936@gmail.com> wrote:+ case 'f': + dev_file = strstr (arg, "="); + if (dev_file == NULL) + return ARGP_ERR_UNKNOWN; + *dev_file = 0; + add_dev_map (arg, dev_file+1); + break;I'd feel better about this patch if it used a long option --device instead of the short option -f.
Do you mean the patch only provides the long option --device?
why? Is there any other function to do it? or should I write the loop to find '=' myself?Also, the use of strstr is pernicious.
Zheng Da
[Prev in Thread] | Current Thread | [Next in Thread] |