[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: The patch of glibc which allows the user to override the pfinet serv
From: |
olafBuddenhagen |
Subject: |
Re: The patch of glibc which allows the user to override the pfinet server |
Date: |
Wed, 13 Aug 2008 08:36:54 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hi,
On Tue, Aug 12, 2008 at 08:05:49PM +0200, zhengda wrote:
> + char *name = NULL;
No need to initialize this -- the asprintf() will overwrite it anyways.
> + if (__asprintf (&name, "SOCK_SERV_%d", domain) > 0)
> + {
> + np = getenv (name);
> + __free (name);
> + }
You need to check whether asprintf() returns an error code (-1), meaning
memory allocation failed, and handle it accordingly -- just like you
handled failure with the explicit malloc() in your original code.
If asprintf() doesn't fail, the getenv() should be done unconditionally.
> + if (__asprintf (&name, "%s/%d", sock_servs, domain) > 0)
> + np = name;
I think you can print to np directly here...
-antrik-
- Re: The patch of glibc which allows the user to override the pfinet server, (continued)
- Re: The patch of glibc which allows the user to override the pfinet server, zhengda, 2008/08/10
- Re: The patch of glibc which allows the user to override the pfinet server, Samuel Thibault, 2008/08/10
- Re: The patch of glibc which allows the user to override the pfinet server, zhengda, 2008/08/10
- Re: The patch of glibc which allows the user to override the pfinet server, Samuel Thibault, 2008/08/10
- Re: The patch of glibc which allows the user to override the pfinet server, zhengda, 2008/08/10
- Re: The patch of glibc which allows the user to override the pfinet server, Samuel Thibault, 2008/08/10
- Re: The patch of glibc which allows the user to override the pfinet server, zhengda, 2008/08/10
- Re: The patch of glibc which allows the user to override the pfinet server, Samuel Thibault, 2008/08/12
- Re: The patch of glibc which allows the user to override the pfinet server, zhengda, 2008/08/12
- Re: The patch of glibc which allows the user to override the pfinet server, zhengda, 2008/08/12
- Re: The patch of glibc which allows the user to override the pfinet server,
olafBuddenhagen <=
- Re: The patch of glibc which allows the user to override the pfinet server, zhengda, 2008/08/13
- Re: The patch of glibc which allows the user to override the pfinet server, Neal H. Walfield, 2008/08/13
- Re: The patch of glibc which allows the user to override the pfinet server, zhengda, 2008/08/13
- Re: The patch of glibc which allows the user to override the pfinet server, Samuel Thibault, 2008/08/13
- Re: The patch of glibc which allows the user to override the pfinet server, olafBuddenhagen, 2008/08/14
- Re: The patch of glibc which allows the user to override the pfinet server, olafBuddenhagen, 2008/08/14
- Re: The patch of glibc which allows the user to override the pfinet server, zhengda, 2008/08/15
- Re: The patch of glibc which allows the user to override the pfinet server, Samuel Thibault, 2008/08/15
- Re: The patch of glibc which allows the user to override the pfinet server, zhengda, 2008/08/15
- Re: The patch of glibc which allows the user to override the pfinet server, Samuel Thibault, 2008/08/15