Re: [patch] setting the fsid on a bootstrap file system

[Neal H Walfield]

> In your remarks and in your code you've used "getuid" a few times where you
> should have used "getpid".  I'll assume that was just a persistent typo and
> nothing more.

It was, excuse me.

> In yet another example of why you should separate semantically distinct
> changes into separate patches, I would be happy to take your comment
> changes and removal of superfluous initializers if I got that patch alone.

I apologize for the inconvenience.  I will try to be more rigorous in
the future.



libdiskfs:

2001-11-20  Neal H Walfield  <neal@cs.uml.edu>

        * diskfs.h (diskfs_boot_filesystem): Documentation fix.


ext2fs:

2001-11-20  Neal H Walfield  <neal@cs.uml.edu>

        (diskfs_synchronous): Zero initializer is superfluous.
        (store): Likewise.
        (store_parsed): Likewise.
        (diskfs_disk_name): Likewise.
        (ext2_debug_flag): Likewise.


Index: libdiskfs/diskfs.h
===================================================================
RCS file: /cvsroot/hurd/hurd/libdiskfs/diskfs.h,v
retrieving revision 1.92
diff -u -p -r1.92 diskfs.h
--- libdiskfs/diskfs.h  2001/08/20 22:44:13     1.92
+++ libdiskfs/diskfs.h  2001/11/21 12:09:23
@@ -149,9 +149,11 @@ extern mach_port_t diskfs_fsys_identity;
    file systems, to give the procserver.  */
 extern char **diskfs_argv;
 
-/* When this is a bootstrap filesystem, the multiboot kernel command line
-   passed from the kernel.  If not a bootstrap filesystem, it is 0, so it
-   can be used to distinguish between the two cases.  */
+/* When this is a bootstrap filesystem, the multiboot kernel command
+   line passed from the kernel.  If not a bootstrap filesystem, it is
+   0.  As such, it can be used to distinguish between the two cases.
+   Note: these is only valid after the arguements have been parsed by,
+   for example, diskfs_init_main.  */
 extern const char *diskfs_boot_command_line;
 #define diskfs_boot_filesystem()       (diskfs_boot_command_line != 0)
 
Index: ext2fs/ext2fs.c
===================================================================
RCS file: /cvsroot/hurd/hurd/ext2fs/ext2fs.c,v
retrieving revision 1.53
diff -u -p -r1.53 ext2fs.c
--- ext2fs/ext2fs.c     2001/01/08 22:33:11     1.53
+++ ext2fs/ext2fs.c     2001/11/21 12:09:24
@@ -47,17 +47,17 @@ char *diskfs_server_name = "ext2fs";
 char *diskfs_server_version = HURD_VERSION;
 char *diskfs_extra_version = "GNU Hurd; ext2 " EXT2FS_VERSION;
 
-int diskfs_synchronous = 0;
+int diskfs_synchronous;
 
 struct node *diskfs_root_node;
 
-struct store *store = 0;
-struct store_parsed *store_parsed = 0;
+struct store *store;
+struct store_parsed *store_parsed;
 
-char *diskfs_disk_name = 0;
+char *diskfs_disk_name;
 
 #ifdef EXT2FS_DEBUG
-int ext2_debug_flag = 0;
+int ext2_debug_flag;
 #endif
 
 /* Ext2fs-specific options.  */