[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug-gv] [PATCH] show beginning of last error message instead if the end

From: Bernhard R. Link
Subject: [bug-gv] [PATCH] show beginning of last error message instead if the end
Date: Mon, 14 Feb 2011 17:31:10 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

cb_appendInfoPopup sets the Text fields focus to the
end of the newly added message which together with the
Scroll code changing the start of a visible area to
the focused point even if there is nothing afterwards
causes sometimes no message being visible at all (as
reported in http://bugs.debian.org/597080).

Even disregarding the suboptimal behaviour of the Scroll
code, the end of a message is usually less interesting
than the beginning, so focus on the beginning of the last
written message instead.
 gv/src/info.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/gv/src/info.c b/gv/src/info.c
index 4400245..a751f7b 100644
--- a/gv/src/info.c
+++ b/gv/src/info.c
@@ -151,13 +151,14 @@ void cb_appendInfoPopup(w, client_data, call_data)
     XtSetArg(args[n], XtNeditType, XawtextAppend);      n++;
     XawTextReplace(infotext, info_length, info_length, &message_block);
-    info_length = info_length + message_block.length;
     XtSetArg(args[0], XtNeditType, XawtextRead);       n++;
     XtSetArg(args[1], XtNinsertPosition, info_length); n++;
+    info_length = info_length + message_block.length;
     skipErrors = gv_infoSkipErrors;
     if (gv_infoSkipErrors)
        if (strstr((char*)call_data, "Error:") || strstr((char*)call_data, 
"ERROR:") || strstr((char*)call_data, "error:"))

reply via email to

[Prev in Thread] Current Thread [Next in Thread]