bug#51968: Missing dependency for Xournal++

[Maxim Cournoyer]

Hi,

Daniel Meißner <daniel.meissner-i4k@ruhr-uni-bochum.de> writes:

> Hi Ludo,
>
> Ludovic Courtès writes:
>> Daniel Meißner skribis:
>>
>>> there is a problem with the package xournalpp on Guix master.  To
>>> reproduce run:
>>>
>>> $ guix shell --pure xournalpp -- xournalpp
>>> [...]
>> How should this be addressed?  Adding ‘gnome-icon-theme’ as a propagated
>> input would be quite unusual, but maybe it’s become necessary?
>
> In fact, I think it should be adwaita-icon-theme.  Anyways, I am not
> familiar with how GTK loads its icons but maybe we could patch the
> sources to look for the icon in the right places so that we can just add
> it as an input?

The problem was fixed in commit d4fbd1ab341de85c1e5c77e0f7adc5aae056be15
by Nicolas.  Since this package relies on SVG icons, it requires an SVG
pixbuf loader to see them.  Wrapping the binary with
GDK_PIXBUF_MODULE_FILE, which points to to a list of pixbuf modules that
were available at build time, resolves the issue, since it includes an
SVG loader.

Wrapping this environment variable is not always a good solution, as
pixbuf loaders are meant to be extensible like plugins, leaving the user
to decide which loaders should be available, and since it takes a single
value, wrapping it means the loaders can no longer be extended simply by
adding new loaders to a profile.

I hope that helps.

Closing.

-- 
Thanks,
Maxim