bug-guix
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#56444: [EXT] Re: bug#56444: Patch to fix Gitolite home directory per


From: Maxime Devos
Subject: bug#56444: [EXT] Re: bug#56444: Patch to fix Gitolite home directory permissions
Date: Mon, 29 Aug 2022 15:19:49 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0

On 29-08-2022 14:57, Thompson, David wrote:

I disagree.  I believe we shouldn't let perfect be the enemy of the good.

I don't think your patch counts as "good" here -- while fixing the bug counts as "good", you are at the same time introducing a new bug (the non-atomicity), which is bad.  You would have to weigh the goodness and the badness to end up with an overall "good" (or maybe "bad", depending on the conclusion), but I'd think that the time required to do such a weighing is better spent by doing a tiny bit of extra effort to implement the new field (it should be very low effort, see other response).

Greetings,
Maxime.

Attachment: OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]