[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#56799: [PATCH v2] gexp: Handle *unspecified* as a gexp input.
From: |
Maxim Cournoyer |
Subject: |
bug#56799: [PATCH v2] gexp: Handle *unspecified* as a gexp input. |
Date: |
Thu, 28 Jul 2022 10:58:52 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Hi,
Maxime Devos <maximedevos@telenet.be> writes:
> On 27-07-2022 22:20, Maxim Cournoyer wrote:
>
>> Fixes <https://issues.guix.gnu.org/56799>.
>>
>> * guix/gexp.scm (gexp->sexp)[*unspecified*]: Quote value when encountering
>> it.
>
> I recommend writing a test case -- this patch does not actually do that.
>
> Instead, it returns the symbol x.
>
> In a ./pre-inst-env guix repl:
>
>> scheme@(guix-user)> ,use (guix)
>> scheme@(guix-user)> ,m (guix gexp)
>> scheme@(guix gexp)> ,enter-store-monad
>> store-monad@(guix gexp) (gexp->sexp #~(list #$*unspecified*)
>> "x86_64-linux" "aarch64-linux-gnu")
>> $1 = (list x)
> I don't know what exact semantics you had in mind but probably not this.
Indeed. Fixed in v3 (which includes a test).
Thanks!
Maxim
- bug#56799: (gnu services configuration) usage of *unspecified* is problematic, (continued)
- bug#56799: (gnu services configuration) usage of *unspecified* is problematic, Tobias Geerinckx-Rice, 2022/07/27
- bug#56799: (gnu services configuration) usage of *unspecified* is problematic, Attila Lendvai, 2022/07/27
- bug#56799: (gnu services configuration) usage of *unspecified* is problematic, Maxim Cournoyer, 2022/07/27
- bug#56799: (gnu services configuration) usage of *unspecified* is problematic, Tobias Geerinckx-Rice, 2022/07/27
- bug#56799: (gnu services configuration) usage of *unspecified* is problematic, Maxim Cournoyer, 2022/07/27
- bug#56799: [PATCH] services: configuration: Step back from *unspecified*., Maxim Cournoyer, 2022/07/27
- bug#56799: (gnu services configuration) usage of *unspecified* is problematic, Maxim Cournoyer, 2022/07/27
- bug#56799: [PATCH v2] gexp: Handle *unspecified* as a gexp input., Maxim Cournoyer, 2022/07/27
- bug#56799: [PATCH v2] gexp: Handle *unspecified* as a gexp input., Maxime Devos, 2022/07/27
- bug#56799: [PATCH v2] gexp: Handle *unspecified* as a gexp input.,
Maxim Cournoyer <=
- bug#56799: [PATCH v3] gexp: Handle *unspecified* as a gexp input., Maxim Cournoyer, 2022/07/28
- bug#56799: (gnu services configuration) usage of *unspecified* is problematic, bokr, 2022/07/28
- bug#56799: (gnu services configuration) usage of *unspecified* is problematic, Maxime Devos, 2022/07/28
- bug#56799: (gnu services configuration) usage of *unspecified* is problematic, Maxim Cournoyer, 2022/07/28