[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41764: `make authenticate` fails to find the keyring branch
|
From: |
Miguel Ángel Arruga Vivas |
|
Subject: |
bug#41764: `make authenticate` fails to find the keyring branch |
|
Date: |
Sat, 24 Oct 2020 17:41:44 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi Ludo,
Thanks for the quick revision.
Ludovic Courtès <ludo@gnu.org> writes:
>> # Authenticate the current Git checkout by checking signatures on every
>> commit.
>> +GUIX_GIT_KEYRING = origin/keyring
>
> You need “?=” or users won’t be able to override it.
The macro definitions provided through the command line are equivalent
to adding these definitions to the end of the file, so this wouldn't
make any difference, so I leave it as only =.
>
> s/git/Git/ in the paragraph, but otherwise LGTM! ‘origin/keyring’ is
> certainly a better default than ‘keyring’.
Pushed with this change as ef6596a20c to master.
Happy hacking!
Miguel
signature.asc
Description: PGP signature