bug-guix
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#42151: [PATCH v3 2/2] image: Do not set journal_model=WAL for the Hu


From: Ludovic Courtès
Subject: bug#42151: [PATCH v3 2/2] image: Do not set journal_model=WAL for the Hurd.
Date: Sat, 11 Jul 2020 16:22:18 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

"Jan (janneke) Nieuwenhuizen" <janneke@gnu.org> skribis:

> This fixes <https://bugs.gnu.org/42151>.
>
> * gnu/system/images/hurd.scm (hurd-initialize-root-partition): Use #:wal-mode 
> #f
> in call to ...
> * gnu/build/image.scm (initialize-root-partition): ... this, add #:wal-mode?
> parameter, pass it to ...
> (register-closure): ... this, add #:wal-mode? parameter, pass it to ...
> * guix/store/database.scm (with-database): ... this, add #:wal-mode?
> parameter, pass it to ...
> (call-with-database): ... this, add #:wal-mode? parameter; when
> set to #f, do not set journal_model=WAL.

[...]

> +++ b/gnu/system/images/hurd.scm
> @@ -61,8 +61,8 @@
>    #~(lambda* (#:rest args)
>        (apply initialize-root-partition
>               (append args
> -                     (list #:make-device-nodes
> -                           make-hurd-device-nodes)))))
> +                     (list #:make-device-nodes make-hurd-device-nodes
> +                           #:wal-mode? #f)))))

IWBN to have an XXX comment here stating why we disable WAL mode on
GNU/Hurd, possibly referencing this issue.  That way, we can eventually
revisit the issue and hopefully get rid of this workaround.

Apart from that the patch LGTM, thanks!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]