[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#42111: tests/syscalls.scm stumbles on network interface aliases
From: |
Marius Bakke |
Subject: |
bug#42111: tests/syscalls.scm stumbles on network interface aliases |
Date: |
Sun, 28 Jun 2020 23:37:07 +0200 |
Ludovic Courtès <ludo@gnu.org> writes:
>> diff --git a/tests/syscalls.scm b/tests/syscalls.scm
>> index 6acaa0b131..7aa16ce3f4 100644
>> --- a/tests/syscalls.scm
>> +++ b/tests/syscalls.scm
>> @@ -382,7 +382,10 @@
>> (member "lo" names))))
>>
>> (test-assert "network-interface-names"
>> - (match (network-interface-names)
>> + (match (filter (lambda (if)
>> + ;; Ignore interface aliases.
>
> Perhaps add “since they don’t show up in (all-network-interface-names)”.
>
>> + (not (string-contains if ":")))
>> + (network-interface-names))
>
> You can use ‘remove’ instead of ‘filter’ + ‘not’.
ah, much clearer with those suggestions, thanks!
Pushed in 5e113cf4424b2746cbf3633cd2106c62b89e5b49.
signature.asc
Description: PGP signature