bug-guix
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#39648: Reverse my commits on GNOME meta-package


From: Gábor Boskovits
Subject: bug#39648: Reverse my commits on GNOME meta-package
Date: Mon, 17 Feb 2020 20:19:11 +0100

Hello Tobias,

Tobias Geerinckx-Rice via Bug reports for GNU Guix <address@hidden>
ezt írta (időpont: 2020. febr. 17., H, 20:03):
>
> Raghav Gururajan 写道:
> > Could you please reverse my following commits:
> >
> > 1) d36fa50fbf8169018193774782fd21f1b13b9c0e
> >
> > 2) 7922b6f795eb575084546ec9bfb9d40508a9378e
> >
> > 3) 8d8c6bffc528b60574f84620bd6c3ee9bfa1173f
> >
> > 4) a8cda7f57992e9ce9ae4a694eba54e3eab42c39b
>
> Copy-pasted from #guix:
>
> Whoa there, that's drastic, let's put that on hold.

I agree.

>
> The first two only add packages (did they break anything? what?),
> the third has no effect on packages if your commit message is
> accurate.

These findings are accurate. I checked the diff of the third, it's ok.

>
> The fourth is the only one that removes packages, and even that
> might be better tweaked (this time: with comments noting what each
> non-core package brings to the GNOME table) than flat-out
> reverted.
>

I believe the fourth can be reverted if needed.

> What do you think?
>
> Kind regards,
>
> T G-R


Best regards,
g_bor
-- 
OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:2506:A96C:CF63:0B21





reply via email to

[Prev in Thread] Current Thread [Next in Thread]