[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35941: Newt installer failure when wifi name is #f
From: |
Mathieu Othacehe |
Subject: |
bug#35941: Newt installer failure when wifi name is #f |
Date: |
Wed, 29 May 2019 09:50:12 +0200 |
User-agent: |
mu4e 1.2.0; emacs 26.2 |
Hey,
> Out of 44 SSIDs around me, only 2 are hidden and they are the only 2 ones
> for which connmanctl does not report the "Name = " line.
>
> That should fix the issue!
Thanks for the investigation ! I guess the attached patch should fix the
issue then :)
Mathieu
>From dd212927d50eeed9b8d16beed1f98228299c8633 Mon Sep 17 00:00:00 2001
From: Mathieu Othacehe <address@hidden>
Date: Wed, 29 May 2019 09:44:44 +0200
Subject: [PATCH] installer: Fix wifi menu crash with hidden SSIDs.
* gnu/installer/connman.scm (<service>): Mention that name may be false.
* gnu/installer/newt/wifi.scm (wifi-services): Filter out wifi services
without name.
Co-authored by: Pierre Neidhardt <address@hidden>
---
gnu/installer/connman.scm | 2 +-
gnu/installer/newt/wifi.scm | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/gnu/installer/connman.scm b/gnu/installer/connman.scm
index ef8cca3952..7f47b9af77 100644
--- a/gnu/installer/connman.scm
+++ b/gnu/installer/connman.scm
@@ -108,7 +108,7 @@
(define-record-type* <service>
service make-service
service?
- (name service-name) ; string
+ (name service-name) ; string or #f
(type service-type) ; string
(path service-path) ; string
(strength service-strength) ; integer
diff --git a/gnu/installer/newt/wifi.scm b/gnu/installer/newt/wifi.scm
index da2f0b56d0..1cb2ef2df3 100644
--- a/gnu/installer/newt/wifi.scm
+++ b/gnu/installer/newt/wifi.scm
@@ -144,6 +144,7 @@ of <service-item> records present in LISTBOX."
(let ((services (connman-services)))
(filter (lambda (service)
(and (string=? (service-type service) "wifi")
+ (service-name service)
(not (string-null? (service-name service)))))
services)))
--
2.17.1