[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35783: Guile-Parted crashes the installer on i686-linux
From: |
Mathieu Othacehe |
Subject: |
bug#35783: Guile-Parted crashes the installer on i686-linux |
Date: |
Sat, 18 May 2019 11:30:21 +0200 |
User-agent: |
mu4e 1.2.0; emacs 26.2 |
Hey Ludo,
> Reverting 7d567af46b4e10ffafb1d0f76b524f5781460598 fixes the problem, so
> I guess this has to do with the fact that the previous partition objects
> (those listed in ‘initial-partitions’) are invalidated or something.
Yes I think that's what happened, even though I don't get why it didn't
cause an issue on x64.
>
> Now we need another way to address
> <https://issues.guix.gnu.org/issue/35731>.
I have a first draft, I'm about to test right now :)
Mathieu
>From 3c6018a448f38e263aeb5a23fbc88d226a048d67 Mon Sep 17 00:00:00 2001
From: Mathieu Othacehe <address@hidden>
Date: Sat, 18 May 2019 11:25:09 +0200
Subject: [PATCH] draft: Fix esp user-partition creation.
---
gnu/installer/newt/partition.scm | 5 +----
gnu/installer/parted.scm | 12 ++++++++----
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/gnu/installer/newt/partition.scm b/gnu/installer/newt/partition.scm
index f8e318fa0d..cd9d46316a 100644
--- a/gnu/installer/newt/partition.scm
+++ b/gnu/installer/newt/partition.scm
@@ -752,10 +752,7 @@ by pressing the Exit button.~%~%")))
(disk-commit disk)
disk)))
(scheme (symbol-append method '- (run-scheme-page)))
- (user-partitions (append
- (auto-partition! disk #:scheme scheme)
- (create-special-user-partitions
- (disk-partitions disk)))))
+ (user-partitions (auto-partition! disk #:scheme scheme)))
(run-disk-page (list disk) user-partitions
#:guided? #t)))
((eq? method 'manual)
diff --git a/gnu/installer/parted.scm b/gnu/installer/parted.scm
index 4ccc0b1f51..ac9098cbde 100644
--- a/gnu/installer/parted.scm
+++ b/gnu/installer/parted.scm
@@ -1001,10 +1001,14 @@ swap partition, a root partition and a home partition."
(mount-point "/home")))))))
(new-partitions* (force-user-partitions-formatting
new-partitions)))
- (create-adjacent-partitions! disk
- new-partitions*
- #:last-partition-end
- (or end-esp-partition 0)))))
+ (append
+ (if esp-partition
+ (partition->user-partition esp-partition)
+ '())
+ (create-adjacent-partitions! disk
+ new-partitions*
+ #:last-partition-end
+ (or end-esp-partition 0))))))
;;
--
2.17.1