[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#27284: [PATCH 1/8] build: Factorize module compilation in (guix buil
From: |
Maxim Cournoyer |
Subject: |
bug#27284: [PATCH 1/8] build: Factorize module compilation in (guix build compile). |
Date: |
Sun, 22 Oct 2017 17:22:37 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Hello,
Ludovic Courtès <address@hidden> writes:
> * guix/build/compile.scm: New file.
> * Makefile.am (MODULES): Add it.
> * build-aux/compile-all.scm: Use it.
> (warnings, file->module, load-module-file)
> (%default-optimizations, %lightweight-optimizations)
> (optimization-options, compile-file*): Remove.
> <top level>: Use 'compile-files'.
> * guix/build/pull.scm (%default-optimizations)
> (%lightweight-optimizations, optimization-options): Remove.
> (build-guix): Rewrite as a call to 'compile-files'.
> * guix/discovery.scm (file-name->module-name): Export.
> ---
> Makefile.am | 1 +
> build-aux/compile-all.scm | 92 ++++----------------------
> guix/build/compile.scm | 165
> ++++++++++++++++++++++++++++++++++++++++++++++
> guix/build/pull.scm | 105 ++++++++---------------------
> guix/discovery.scm | 4 +-
> 5 files changed, 209 insertions(+), 158 deletions(-)
> create mode 100644 guix/build/compile.scm
[...]
This and the other patches in this series look fine to me. Maybe the
change log items could be a bit more precise about what got moved rather
than removed, but given the amount of refactoring this might be too
verbose to be worth it?
Maxim
- bug#27284: [PATCH 0/8] 'guix pull' creates several derivations, Ludovic Courtès, 2017/10/20
- bug#27284: [PATCH 3/8] discovery: Move 'file-name->module-name' to (guix modules)., Ludovic Courtès, 2017/10/20
- bug#27284: [PATCH 2/8] build: Honor make's '-j' flag., Ludovic Courtès, 2017/10/20
- bug#27284: [PATCH 4/8] gexp: Add 'file-union'., Ludovic Courtès, 2017/10/20
- bug#27284: [PATCH 7/8] gexp: 'directory-union' has a #:quiet? parameter., Ludovic Courtès, 2017/10/20
- bug#27284: [PATCH 1/8] build: Factorize module compilation in (guix build compile)., Ludovic Courtès, 2017/10/20
- bug#27284: [PATCH 1/8] build: Factorize module compilation in (guix build compile).,
Maxim Cournoyer <=
- bug#27284: [PATCH 1/8] build: Factorize module compilation in (guix build compile)., Ludovic Courtès, 2017/10/22
- bug#27284: [PATCH 1/8] build: Factorize module compilation in (guix build compile)., Eric Bavier, 2017/10/22
- bug#27284: [PATCH 1/8] build: Factorize module compilation in (guix build compile)., Ludovic Courtès, 2017/10/22
- bug#27284: [PATCH 1/8] build: Factorize module compilation in (guix build compile)., Eric Bavier, 2017/10/22
- bug#27284: [PATCH 1/8] build: Factorize module compilation in (guix build compile)., Ludovic Courtès, 2017/10/23
bug#27284: [PATCH 5/8] gexp: Add 'directory-union'., Ludovic Courtès, 2017/10/20
bug#27284: [PATCH 6/8] union: Parametrize the symlink procedure ., Ludovic Courtès, 2017/10/20
bug#27284: [PATCH 8/8] DRAFT Add (guix self) and use it when pulling., Ludovic Courtès, 2017/10/20