[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#28756: Substitute download progress bar doesn't reach 100%
From: |
Ludovic Courtès |
Subject: |
bug#28756: Substitute download progress bar doesn't reach 100% |
Date: |
Tue, 17 Oct 2017 14:03:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
address@hidden (宋文武) skribis:
> address@hidden (Ludovic Courtès) writes:
>
>> address@hidden (宋文武) skribis:
>>
>>> From 6a3fa69f96fc2e3e074a9275066640ddfee57fd2 Mon Sep 17 00:00:00 2001
>>> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <address@hidden>
>>> Date: Sat, 14 Oct 2017 22:45:55 +0800
>>> Subject: [PATCH] guix: substitute: Report the last progress in the child
>>> process.
>>>
>>> Fixes <https://bugs.gnu.org/28756>.
>>>
>>> * guix/utils.scm (filtered-port): Close the 'input' port for the current
>>> process, and close it upon exit in the child process.
>>> * guix/scripts/substitute.scm (progress-substitution): Display "\n\n" after
>>> the reporter has finished.
>>
>> LGTM!
>>
>> You could commit the utils.scm change separately because it’s a bug-fix
>> in its own right.
>>
>
> Pushed, thanks! I think the utils.scm change alone (without the remove
> of '(close-port progress') and comment) didn't fix this particular bug
> clearly so I didn't seperate it..
Sounds reasonable. Thank you!
Ludo’.
- bug#28756: Substitute download progress bar doesn't reach 100%, Leo Famulari, 2017/10/08
- bug#28756: Substitute download progress bar doesn't reach 100%, Ludovic Courtès, 2017/10/09
- bug#28756: Substitute download progress bar doesn't reach 100%, 宋文武, 2017/10/12
- bug#28756: Substitute download progress bar doesn't reach 100%, 宋文武, 2017/10/14
- bug#28756: Substitute download progress bar doesn't reach 100%, Ludovic Courtès, 2017/10/15
- bug#28756: Substitute download progress bar doesn't reach 100%, 宋文武, 2017/10/16
- bug#28756: Substitute download progress bar doesn't reach 100%, Ludovic Courtès, 2017/10/17
- bug#28756: Substitute download progress bar doesn't reach 100%, 宋文武, 2017/10/17
- bug#28756: Substitute download progress bar doesn't reach 100%,
Ludovic Courtès <=
Message not available