[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#27007: [PATCH 1/2] bootloader: Use menu-entry to define custom bootl
bug#27007: [PATCH 1/2] bootloader: Use menu-entry to define custom bootloader entries.
Tue, 06 Jun 2017 10:14:24 +0200
mu4e 0.9.18; emacs 25.2.1
> Do we still need ‘device-mount-point’ now? For the dual-boot use case,
> I don’t see how this would be used.
Nope, you're right it's not needed in <menu-entry>.
>> + (initrd (menu-entry-initrd menu-entry))))
> It’s weird to set ‘store-device’ and ‘store-mount-point’ here since
> there’s no store (at least when defining a menu entry for another distro
> or OS). Should we set them to #f?
Sound ok !
> BTW, this is unrelated to this patch series, but I think ‘boot-name’
> should be renamed to ‘bootloader-name’ since that’s what it is.
> Thank you for working on this!
Thanks for reviewing :)