[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#25242: Cannot build source derivations with a custom TMPDIR
From: |
Leo Famulari |
Subject: |
bug#25242: Cannot build source derivations with a custom TMPDIR |
Date: |
Wed, 21 Dec 2016 11:41:49 -0500 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Wed, Dec 21, 2016 at 10:20:20AM +0100, Ludovic Courtès wrote:
> Good catch!
>
> AFAICS the flaw is that there’s one place where I wrote:
>
> if (useChroot && !isBuiltin(drv))
>
> while several other places just do something like:
>
> if (useChroot)
>
> Could the patch below solve the problem?
I'm not sure how to test patches to the daemon. Does it require creating
a new guix-devel snapshot?
> diff --git a/nix/libstore/build.cc b/nix/libstore/build.cc
> index e823001..38048ce 100644
> --- a/nix/libstore/build.cc
> +++ b/nix/libstore/build.cc
> @@ -1680,7 +1680,11 @@ void DerivationGoal::startBuilder()
> % drv.platform % settings.thisSystem % drvPath);
> }
>
> - useChroot = settings.useChroot;
> + /* Note: built-in builders are *not* running in a chroot environment so
> + that we can easily implement them in Guile without having it as a
> + derivation input (they are running under a separate build user,
> + though). */
> + useChroot = settings.useChroot && !isBuiltin(drv);
>
> /* Construct the environment passed to the builder. */
> env.clear();
> @@ -2048,12 +2052,7 @@ void DerivationGoal::runChild()
> commonChildInit(builderOut);
>
> #if CHROOT_ENABLED
> - /* Note: built-in builders are *not* running in a chroot environment
> - so that we can easily implement them in Guile without having it as
> - a derivation input (they are running under a separate build user,
> - though). */
> -
> - if (useChroot && !isBuiltin(drv)) {
> + if (useChroot) {
> /* Initialise the loopback interface. */
> AutoCloseFD fd(socket(PF_INET, SOCK_DGRAM, IPPROTO_IP));
> if (fd == -1) throw SysError("cannot open IP socket");
>
> Thanks!
>
> Ludo’.