bug-guix
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#21399: Emacs: Guix Package Info omits some inputs


From: Alex Kost
Subject: bug#21399: Emacs: Guix Package Info omits some inputs
Date: Wed, 02 Sep 2015 18:20:25 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Ludovic Courtès (2015-09-02 16:06 +0300) wrote:

> Hello,
>
> For ‘r’, the *Guix Package Info* buffer omits IcedTea from the set of
> inputs.  It shows this:
>
>
> Inputs            : openblas-0.2.14, cairo-1.14.2, gfortran-4.9.3, icu4c-55.1,
>                     lapack-3.5.0, libjpeg-9a, libpng-1.5.21, libtiff-4.0.3,
>                     libxt-1.1.4, pcre-8.37, readline-6.3, zlib-1.2.7
>
> whereas the recipe has this:
>
>
>     (inputs
>      `(("openblas" ,openblas)
>        ("cairo" ,cairo)
>        ("gfortran" ,gfortran)
>        ("icu4c" ,icu4c)
>        ("icedtea6" ,icedtea6 "jdk")
>        ("lapack" ,lapack)
>        ("libjpeg" ,libjpeg)
>        ("libpng" ,libpng)
>        ("libtiff" ,libtiff)
>        ("libxt" ,libxt)
>        ("pcre" ,pcre)
>        ("readline" ,readline)
>        ("zlib" ,zlib)))
>
> My guess is that somewhere, the triplet for IcedTea is silently filtered
> out.

Yes, you are right, it is filtered in ‘package-inputs-names’ in
"emacs/guix-main.scm".  The easiest fix would be the following

diff --git a/emacs/guix-main.scm b/emacs/guix-main.scm
index 8d3a881..636d524 100644
--- a/emacs/guix-main.scm
+++ b/emacs/guix-main.scm
@@ -245,7 +245,7 @@ Example:
 (define (package-inputs-names inputs)
   "Return a list of full names of the packages from package INPUTS."
   (filter-map (match-lambda
-               ((_ (? package? package))
+               ((_ (? package? package) _ ...)
                 (package-full-name package))
                (_ #f))
               inputs))
However, I think it would be better to have "icedtea6-1.13.7:jdk"
instead of "icedtea6-1.13.7" in the "Inputs".  This requires modifying
‘full-name->name+version’ procedure so that pressing such
"<name>-<version>:<out>" buttons will also work.

Thank you for noticing this.  The patch is attached.

Attachment: 0001-emacs-Add-support-for-triplet-package-inputs.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]