[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#17935: make check failed
From: |
Alex Kost |
Subject: |
bug#17935: make check failed |
Date: |
Sat, 05 Jul 2014 17:33:46 +0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Ludovic Courtès (2014-07-05 13:42 +0400) wrote:
>
> [...]
>
>> So I think the problem with the patch is that address@hidden@/store”
>> directory does not exist when “`cd "@GUIX_TEST_ROOT@/store"; pwd -P`” is
>> being invoked.
>
> Oops, indeed. Could you try this version, again from a directory with
> symlinks?
>
> diff --git a/test-env.in b/test-env.in
> index a3b3536..9d0c8cc 100644
> --- a/test-env.in
> +++ b/test-env.in
> @@ -27,8 +27,15 @@
> if [ -x "@abs_top_builddir@/guix-daemon" ]
> then
> NIX_SETUID_HELPER="@abs_top_builddir@/nix-setuid-helper" # normally
> unused
> - NIX_IGNORE_SYMLINK_STORE=1 # in case the store is a symlink
> NIX_STORE_DIR="@GUIX_TEST_ROOT@/store"
> +
> + # Do that because store.scm calls `canonicalize-path' on it.
> + mkdir -p "$NIX_STORE_DIR"
> +
> + # Canonicalize the store directory name in an attempt to avoid symlinks
> in
> + # it or its parent directories. See <http://bugs.gnu.org/17935>.
> + NIX_STORE_DIR="`cd "@GUIX_TEST_ROOT@/store"; pwd -P`"
> +
> NIX_LOCALSTATE_DIR="@GUIX_TEST_ROOT@/var"
> NIX_LOG_DIR="@GUIX_TEST_ROOT@/var/log/guix"
> NIX_DB_DIR="@GUIX_TEST_ROOT@/db"
> @@ -71,9 +78,6 @@ then
> GUIX_ALLOW_UNAUTHENTICATED_SUBSTITUTES
> \
> NIX_CONF_DIR XDG_CACHE_HOME
>
> - # Do that because store.scm calls `canonicalize-path' on it.
> - mkdir -p "$NIX_STORE_DIR"
> -
> # Launch the daemon without chroot support because is may be
> # unavailable, for instance if we're not running as root.
> "@abs_top_builddir@/pre-inst-env" \
>
> Thanks in advance,
> Ludo’.
I have tried that. Unfortunately 2 tests failed. I'm attaching
"test-suite.log" and 2 "package.log"-s: the first "package.log" is the
one from the failed built (from a symlinked path) and the second one is
from the succeeded built (from a real path).
Also I think
NIX_STORE_DIR="`cd "@GUIX_TEST_ROOT@/store"; pwd -P`"
may be replaced with:
NIX_STORE_DIR="`realpath "@GUIX_TEST_ROOT@/store"`"
test-suite.log
Description: test-suite.log
packages.log
Description: bad packages.log
packages.log
Description: good packages.log
- bug#17935: make check failed, Alex Kost, 2014/07/04
- bug#17935: make check failed, Ludovic Courtès, 2014/07/04
- bug#17935: make check failed, Alex Kost, 2014/07/04
- bug#17935: make check failed, Ludovic Courtès, 2014/07/04
- bug#17935: make check failed, Alex Kost, 2014/07/05
- bug#17935: make check failed, Ludovic Courtès, 2014/07/05
- bug#17935: make check failed,
Alex Kost <=
- bug#17935: make check failed, Ludovic Courtès, 2014/07/05
- bug#17935: make check failed, Alex Kost, 2014/07/05
- bug#17935: make check failed, Ludovic Courtès, 2014/07/05
- bug#17935: make check failed, Alex Kost, 2014/07/05
- bug#17935: make check failed, Ludovic Courtès, 2014/07/06