[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add Grue Hunter.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] gnu: Add Grue Hunter. |
Date: |
Thu, 30 May 2013 13:53:59 +0200 |
User-agent: |
Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3 (gnu/linux) |
Nikita Karetnikov <address@hidden> skribis:
>> See ‘package-from-tarball’ for an example, in bootstrap.scm.
>
> Thanks. Can I push the attached patch along with this one [1,2]?
OK for [1].
Comments about the rest:
> Two questions, though:
>
> 1. Is it necessary to use 'begin' here?
>
> (begin
> (mkdir out)
> (copy-file tarball "grue-hunter.tar.gz")
> ...)
Yes, because it’s a sequence of instructions.
> 2. I'd like to use
>
> (patch-shebang (string-append bin "/grue-hunter")
> (list perl))
Should be (list (string-append perl "/bin")).
Free free to commit after that change if it works as expected.
> + (synopsis "Text adventure game")
> + (description
> + "Grue Hunter is a text adventure game written in Perl. You must make
> +your way through an underground cave system in search of the Grue. Can you
> +capture it and get out alive?")
> + (license agpl3+)))
The indentation of ‘(license’ differs from the lines above.
Thanks,
Ludo’.
- Grue Hunter: Can't create directories in the store, Nikita Karetnikov, 2013/05/14
- Re: Grue Hunter: Can't create directories in the store, Cyril Roelandt, 2013/05/14
- Re: Grue Hunter: Can't create directories in the store, Ludovic Courtès, 2013/05/15
- Re: Grue Hunter: Can't create directories in the store, Nikita Karetnikov, 2013/05/15
- Re: Grue Hunter: Can't create directories in the store, Ludovic Courtès, 2013/05/16
- Re: Grue Hunter: Can't create directories in the store, Nikita Karetnikov, 2013/05/24
- Re: Grue Hunter: Can't create directories in the store, Ludovic Courtès, 2013/05/24
- Re: Grue Hunter: Can't create directories in the store, Nikita Karetnikov, 2013/05/24
- Re: Grue Hunter: Can't create directories in the store, Ludovic Courtès, 2013/05/24
- [PATCH] gnu: Add Grue Hunter., Nikita Karetnikov, 2013/05/29
- Re: [PATCH] gnu: Add Grue Hunter.,
Ludovic Courtès <=