[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] distro: Add GNU Wget.

From: Ludovic Courtès
Subject: Re: [PATCH] distro: Add GNU Wget.
Date: Sun, 25 Nov 2012 16:03:53 +0100
User-agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux)


Nikita Karetnikov <address@hidden> skribis:

> (I attached the patch.)

Applied.  I added this line to fix chroot builds:

       (alist-cons-before 'build 'patch-/usr/bin/env
                          (lambda _
                            (for-each patch-shebang
                                      '("doc/texi2pod.pl" "tests/run-px")))

> I'm getting this warning:
> WARNING: (distro packages wget): imported module (distro packages
> gettext) overrides core binding `gettext'
> According to this message, [1] there is no need to worry, but I'd like
> to be sure. Could you clarify?

Indeed, it’s just saying that the core ‘gettext’ binding is being
overridden by ours within (distro packages wget).

To silence the warning, perhaps we could rename ‘gettext’ to
‘gnu-gettext’, as I did for GNU Make.  WDYT?

> Also, './pre-inst-env guix-import ../nixpkgs-github wget' listed the
> following:
> (inputs ...
>   ("perl-libwww-perl" ,perl-libwww-perl))
> But it builds fine without this line. Can we omit it?

It’s an optional dependency (a Perl package) used to run some of the
tests.  Currently, we see a lot of these warnings during “make check”:

  Can't locate HTTP/Daemon.pm in @INC (@INC contains: ../tests 
 /nix/store/a0si4l5cnbdh7ypwnz7k2knfpli8agra-perl-5.16.1/lib/perl5/5.16.1 .) at 
../tests/HTTPServer.pm line 6.

This is because we lack libwww-perl, I guess.  Something to add


reply via email to

[Prev in Thread] Current Thread [Next in Thread]