[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41956: [PATCH] ice-9: exceptions: Properly format the error message.
From: |
Ricardo Wurmus |
Subject: |
bug#41956: [PATCH] ice-9: exceptions: Properly format the error message. |
Date: |
Sun, 28 Jun 2020 06:31:44 +0200 |
User-agent: |
mu4e 1.4.10; emacs 26.3 |
Hi Maxim,
>> here’s what I did in the REPL:
>>
>> scheme@(guile-user)> ,m (ice-9 exceptions)
>> scheme@(ice-9 exceptions)> (define (my/guile-system-error-converter key args)
>> (apply (case-lambda
>> ((subr msg-args msg errno . rest)
Here I changed the order: “msg-args” appears before “msg”. I don’t know
why the converter that’s currently in Guile assumes that the message
comes first.
>> scheme@(ice-9 exceptions)> (set! guile-exception-converters (acons
>> 'system-error my/guile-system-error-converter guile-exception-converters))
guile-exception-converters is a lookup table in (ice-9 exceptions). It
associates error keys with converter procedures. Since
canonicalize-path throws a 'system-error I chose to only update the
'system-error association. I didn’t want to affect all the other
converter procedures that end up using the common converter; maybe they
should be affected — I don’t know because I don’t have any test cases
other than canonicalize-path.
> This brings embeds the definition of `guile-common-exceptions' into
> `guile-system-error-converter', with a single change:
>
> (make-exception-with-message msg) --> (apply make-exception-with-message
> msg msg-args)
>
> What is the magic I fail to see?
I cannot parse your sentence, so I’m not sure what you mean.
> Is this fix proper to be merged into the original
> guile-common-exceptions procedure?
I think we should add tests of different exceptions with different keys
to be sure that modifying the common handler doesn’t have any unexpected
side-effects.
--
Ricardo
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message., Maxim Cournoyer, 2020/06/19
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message., maxim . cournoyer, 2020/06/20
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message., Bengt Richter, 2020/06/20
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message., Maxim Cournoyer, 2020/06/20
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message., Ricardo Wurmus, 2020/06/25
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message., Bengt Richter, 2020/06/25
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message., Maxim Cournoyer, 2020/06/28
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message., Bengt Richter, 2020/06/28
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message., Maxim Cournoyer, 2020/06/28
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message.,
Ricardo Wurmus <=