[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#41956: [PATCH] ice-9: exceptions: Properly format the error message.
From: |
maxim . cournoyer |
Subject: |
bug#41956: [PATCH] ice-9: exceptions: Properly format the error message. |
Date: |
Sat, 20 Jun 2020 01:46:13 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> Hello,
>
> I had this problem in Guix where 'guix deploy my-config.scm' would
> unhelpfully report an error like:
>
> guix deploy: error: failed to deploy my-host: ~A: ~S
>
> Digging a bit, I could reproduce at the REPL with:
>
> (guard (c ((message-condition? c)
> (format #t "error: ~a~%" (condition-message c))))
> ;; This is what (canonicalize-path "/do/not/exist) ends up doing:
> (throw 'system-error "canonicalize-path" "~A" '("No such file or
> directory")))
>
> --> error: ~A
[...]
Unfortunately the previous patch breaks the tests, with errors like:
ERROR: bytevectors.test: Datum Syntax: incorrect prefix - arguments:
((wrong-type-arg "apply" "Apply to non-list: ~S" (#\i) (#\i)))
I'm out of ideas for now, I last tried:
--8<---------------cut here---------------start------------->8---
modified module/ice-9/exceptions.scm
@@ -189,7 +189,10 @@
((subr msg margs . _)
(make-exception
(make-exception-with-origin subr)
- (make-exception-with-message msg)
+ (let ((msg (if (null? margs)
+ msg
+ (apply simple-format #f msg margs))))
+ (make-exception-with-message msg))
(make-exception-with-irritants margs)))
(_ (make-exception-with-irritants args)))
args))
--8<---------------cut here---------------end--------------->8---
To the same effect.
Maxim
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message., Maxim Cournoyer, 2020/06/19
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message.,
maxim . cournoyer <=
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message., Bengt Richter, 2020/06/20
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message., Maxim Cournoyer, 2020/06/20
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message., Ricardo Wurmus, 2020/06/25
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message., Bengt Richter, 2020/06/25
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message., Maxim Cournoyer, 2020/06/28
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message., Bengt Richter, 2020/06/28
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message., Maxim Cournoyer, 2020/06/28
- bug#41956: [PATCH] ice-9: exceptions: Properly format the error message., Ricardo Wurmus, 2020/06/28