[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH]: deadlock in make_struct()
|
From: |
Andy Wingo |
|
Subject: |
Re: [PATCH]: deadlock in make_struct() |
|
Date: |
Mon, 17 Nov 2008 22:41:35 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) |
Hi Linas,
I was about to write about how your patch looked incorrect to me,
because GC could see a half-initialized struct (and potentially sweep
it, with a bad free function); but I just looked back and back into the
history, and could not find why the critical section was there. It has
been there since Jim Blandy imported the whole mess into CVS in 1996.
I would like to say that your patch is OK, but since you don't use
structs very much in your code AFAIK I'm a bit hesitant. Can anyone
think of a reason why this allocation codepath would have SCM_DEFER_INTS
around it?
Andy
--
http://wingolog.org/