[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gtypist] ideas, implementations, patches.

From: Felix Natter
Subject: Re: [bug-gtypist] ideas, implementations, patches.
Date: Sat, 16 Jul 2016 19:46:30 +0200
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.4 (gnu/linux)

hello clutton,

clutton <address@hidden> writes:
> I've deleted old autoall branch and created clear new one.
> Please review. I tested this on several Linuxe's and on
> Free/Net/Open|BSD. Would like to see it tested on MacOS (should be fine
> too). And windows, I have no idea how you guys make it build for
> windows...
> The approach is of more extreme nature the previous one, but it seems
> good with autotools philosophy (testing capabilities).
> If everything is ok, the branch is ready for merging. If not: there are
> my few thoughts: the test code could be separated to m4 directory (I
> tried using ax_with_curses.m4 but it's more Linux only). Maybe using
> resolv.h for headers (perfect autotools solution), but I'm ok with how
> my patch solves everything now...

Just one small thing: What if ncursesw/curses.h is in prefix=/usr/local
instead of prefix=/usr? Maybe it would suffice to:

diff --git a/configure.ac b/configure.ac
index 7477ece..636c6e5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -71,7 +71,7 @@ AC_DEFUN([IS_CURSES_WIDE], [
    AS_IF([test "x$1" = "xncursesw/curses.h"], [
-     NCURSES_CPPFLAGS=-I/usr/include/ncursesw
+     NCURSES_CPPFLAGS="-I/usr/include/ncursesw -I/usr/local/include/ncursesw"

Of course there may be other prefixes.
In this way, the #include <ncursesw/ncurses.h> is superior :-p

Cheers and Best Regards,
Felix Natter

reply via email to

[Prev in Thread] Current Thread [Next in Thread]