bug-gtypist
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gtypist] Patch to fix typos in gtypist lessons


From: Tim Marston
Subject: Re: [bug-gtypist] Patch to fix typos in gtypist lessons
Date: Sun, 28 Apr 2013 13:10:00 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Hi Chris,

On Sat, Apr 27, 2013 at 07:30:45PM -0400, Chris Jones wrote:
> I'm keeping track of typos in gtypist.typ and other lessons via
> a "private" patch in my $HOME directory.
> 
> No idea if you're interested and if so how it should be maintained and
> formatted..

Excellent!  Yes please, we'd definitely be interested in lesson
corrections.  Just a patch, such as you've provided, is absolutely
fine.

> Attaching current state of the gtypist.typ patch as a sample for your
> review.

Great, thanks!

I had a quick look through the patch, and there were just a couple of
points that I should mention...

The patch is generated the wrong way round (i.e. the + and - lines are
the wrong way round), so it currently removes the corrections and adds
the errors!

Also, I don't think the following change is correct.  The full-stop at
the end of "lbs." indicates an abbreviation, not the end of a sentence.

> --- gtypist.typ       2013-04-25 13:36:52.000000000 -0400
> +++ /usr/share/gtypist/gtypist.typ    2013-01-02 12:49:41.000000000 -0500
> @@ -4313,8 +4313,8 @@
>  I:(6)
>  *:_V_R_L125
>  D:d3d k8k d3d k8k d3d k8k d3d k8k 318 813 138 813 381
> - :13 lbs. lamb roast; 38 lbs. lamb chops; 8 lbs. bananas;
> - :31 lbs. lamb chops; 83 lbs. lamb roast; 3 lbs. peaches;
> + :13 lbs.  lamb roast; 38 lbs. lamb chops; 8 lbs. bananas;
> + :31 lbs.  lamb chops; 83 lbs. lamb roast; 3 lbs. peaches;
>   :
>   :lie 3 dye 3 pie 3 dye 3 Fiji 8 Fiji 8 Fiji 8
>   :18 cans grape juice; 138 cans prune juice; 4 lbs. coffee;

I'll apply the patch now (minus the above change).  If you want to keep
sending us updates to your patch, we would appreciate them very much
indeed!

Thanks again, Chris.

Kind regards,

-- 
Tim Marston
ed.am



reply via email to

[Prev in Thread] Current Thread [Next in Thread]