Re: [bug-gtypist] GTypist 2.9 package

[Felix Natter]

Daniel Leidert <address@hidden> writes:

hi Daniel,

> Hi Felix,
> Am Montag, den 14.11.2011, 15:38 +0100 schrieb Felix Natter:
>> Daniel Leidert <address@hidden> writes:
>> > Am Montag, den 14.11.2011, 09:31 +0100 schrieb Felix Natter:
>> >> hi Daniel,
>> >> 
>> >> there is a small problem with your gtypist 2.9 package: Why do you depend 
>> >> on
>> >> libncurses?
>> >
>> > The package depends on libncursesw5 not libncurses5.
>> 
>> I think it depends on both (from http://packages.debian.org/sid/gtypist).
>
> What you see is, that for some architectures version 2.9 has not yet
> been built. On those architectures, gtypist 2.8.x depends on ncurses5.
> Just wait a few days until gtypist has been built on all architectures
> and uploaded and then you'll only see ncursesw as dependency on this
> site.

Ah, OK. good to know.

>
>> > The configure script checks for it and prefers ncursesw over ncurses.
> [..]
>> >> if test -n "$HAVE_NCURSESW_H" -a -n "$HAVE_LIBNCURSESW";  then
>> >>        LIBS="-lncursesw $LIBS"
> [..]
>
>> Yes, the comments are useless and I'have just commited a change to
>> remove this from git.
>
> Saw it. But the code above, which you left, is also not necessary.
> AC_CHECK_LIB adds -lncursesw to $LIBS automatically if libncursesw is
> available :) See the autoconf documentation.

Yes (but only if [action-if-found] is not specified). 
I now replaced this by one AC_CHECK_LIB, it seems like we don't need
BSD Curses right now (ncurses seems to work on Mac OS X and *BSD too):

AC_CHECK_LIB(ncursesw, add_wch, HAVE_LIBNCURSESW=1)
AC_CHECK_HEADER(ncursesw/ncurses.h, HAVE_NCURSESW_H=1)

# sanity check for libncursesw: 
if test -n "$HAVE_NCURSESW_H" -a -n "$HAVE_LIBNCURSESW";  then
   LIBS="-lncursesw $LIBS"
else
   echo -e "Error:  both library and header files for the ncursesw library\n"\
        "are required to build this package.  See INSTALL file for"\
        "further information. On Debian/Ubuntu you need to install 
libncursesw5-dev."
   exit 1;
fi

> [snip]
>> > BTW: If your related to gtypist upstream sources, would you mind
>> > checking out the open bug reports here:
>> > http://bugs.debian.org/src:gtypist
>> 
>> Yes, sure, we have taken care of most of them already, but we should
>> definitely close all of them ASAP.
>
> Thanks for the explanation. I'll handle those being my part :) with the
> next upload. Might take a few days.

Thanks and Best Regards,
-- 
Felix Natter