Re: [bug-gsrc] bash

[carl hansen]

On Fri, Sep 26, 2014 at 3:48 AM, Brandon Invergo <address@hidden> wrote:

Hi Carl,

> "Bash" in the news. I decided to upgrade it to lastest patchlevel , 25.

 
> Maybe you could give me a few clues.
> Only had to change 2 files, Makefile and sha246sum

My usual update workflow is the following:

1. edit Makefile

  ...

ok, I think I see it. I was unfamiliar with procedure with bzr, easy enough

I hope to make myself useful in the future with other updates.
 

> The glitch I mentioned:
  ...
> had a trailing space! Surprized me; a bug in make?

Weird, I hadn't encountered that before but I can confirm that it
happens for me too.  It strikes me not as a bug but as a side effect of
not needing to enclose variable values in quotes; the value includes
everything up to the newline.  We could use Make's 'strip' function to
remove the whitespace when such compound strings are built (in this
case, "packageDESTDIR", line 623 in gar.lib.mk).  It doesn't look like
there will be many places that need such a change (mainly wherever
GARNAME and GARVERSION are used in gar.mk and gar.lib.mk).  I'll work on
that.

-brandon

 

If not a bug, at least a misfeature. Something make hackers should know, now I do.