bug-gsl
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

cspline, bsd/libc5 rng, matrix/vector test suite issues


From: Ryan McKinnon
Subject: cspline, bsd/libc5 rng, matrix/vector test suite issues
Date: Tue, 6 Jun 2023 12:05:02 +0000

Hi,


I noticed a few issues running make check on the latest source (b6c4b6e, 
obtained via savannah git clone, compiled using gcc 12.2.0 for both O2 and O3, 
on linux x86_64):


* cspline test segfaults when there are only two data points, because it tries 
to solve a 0x0 linear system and ultimately write alpha[0] = diag[0] inside 
solve_tridiag

* bsd_initialize and libc5_initialize can have signed integer overflow, 
reported in the rng test suite by ubsan

* test suites for matrix and vector did not properly free all memory, reported 
by asan


I am attaching a patch that I believe addresses the issues.  (I have not 
submitted a patch before, so if I did something wrong, just let me know.)


Ryan

Attachment: make_check.patch
Description: make_check.patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]