[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-gsl] Bug in akima.c - indexing of the arrays is out of order
From: |
Patrick Alken |
Subject: |
Re: [Bug-gsl] Bug in akima.c - indexing of the arrays is out of order |
Date: |
Thu, 2 Nov 2017 15:03:55 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
Thanks, but which example are you referring to? The example in the
manual comparing the different 1D methods?
On 11/02/2017 01:02 PM, Thomas Walter wrote:
> Hello Patrick,
>
> resending is no problem.
> My first mail can be ignored. I made also a mistake with all the indices.
> My second mail contained:
>
> Hello Patrick,
>
> sorry, I missunderstood the boundaries of the for-loops.
>
> On the other hand, I think I found the root cause of the
> misbehavior of the akima algorithm.
> It is located in function akima_calc() in the block
>
> if (NE_next == 0.0)
> {
> tL_ip1 = m[i+1]; /* here '+1' was missing; because
> after adding, the graph looks much better */
> }
>
> All variables related to the next with indices have a '+1' except
> 'tl_ip1'.
> Replacing 'm[i]' by 'm[i+1]' results in a smooth spline curve.
>
> Kind Regards,
> Thomas
>
> With this small change the fitted line of the example is smooth.
>
> With kind regards
> Thomas
>
> On 2017-11-01 10:12, Patrick Alken wrote:
>> Hello, I am trying to organize the recent bug reports, but I noticed
>> that your two emails about akima.c did not contain any text in the
>> email. Could you resend the bug report to me?
>>
>> Thanks,
>> Patrick
>>
>> On 08/24/2017 10:51 PM, Thomas Walter wrote:
>>
>>
>
> --
> Thomas Walter
> address@hidden
> +49 176 82185785