[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gsl] [Help-gsl] test release for gsl-2.0

From: Patrick Alken
Subject: Re: [Bug-gsl] [Help-gsl] test release for gsl-2.0
Date: Wed, 28 Oct 2015 10:42:33 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

Thanks, I've never used that tool before. I've corrected these issues


On 10/28/2015 09:29 AM, David Binderman wrote:
Hello there,

I tried out the test release with the static analyser cppcheck and found the 


Memory leak:

[gsl-1.99.90/linalg/tridiag.c:237]: (error) Memory leak: alpha
[gsl-1.99.90/linalg/tridiag.c:237]: (error) Memory leak: c
[gsl-1.99.90/linalg/tridiag.c:237]: (error) Memory leak: delta
[gsl-1.99.90/linalg/tridiag.c:237]: (error) Memory leak: gamma
[gsl-1.99.90/linalg/tridiag.c:237]: (error) Memory leak: z

Source code is

          return GSL_SUCCESS;


[gsl-1.99.90/specfunc/bessel_sequence.c:106]: (style) Array index 'i' is used 
before limits check.

Source code is

    while(v[i] < x_small && i < size) {

Suggest sanity check array index before use.


[gsl-1.99.90/specfunc/expint.c:380]: (style) Same expression in both branches 
of ternary operator.

Source code is

   result->val = (scale ? 1.0 : 1.0);

Maybe this is a typo ?


[gsl-1.99.90/multifit/test_nonlinear.c:367]: (warning) printf format string 
requires 2 parameters but 3 are given.

Source code is

  printf("testing %s/%s...", sname, pname, x0_scale);

I also did a test build with the latest development version of gcc with the 
following flags
"-g -O3 -march=native -Wall -Wextra -Wlogical-op -Wshift-overflow" and could 
find no
significant warnings.


David Binderman


reply via email to

[Prev in Thread] Current Thread [Next in Thread]