[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-gsl] Bugs in I/O for gsl_matrix_complex
From: |
Brian Gough |
Subject: |
Re: [Bug-gsl] Bugs in I/O for gsl_matrix_complex |
Date: |
Mon, 17 Oct 2011 14:36:40 +0100 |
User-agent: |
Wanderlust/2.15.6 (Almost Unreal) Emacs/23.3 Mule/6.0 (HANACHIRUSATO) |
At Sun, 16 Oct 2011 15:33:52 -0500,
Rhys Ulerich wrote:
> > I've discovered a bug in the I/O for complex matrices. If tda is larger
> > than the actual size of the matrix, the fwrite() function called
> > internally writes the wrong blocks of data to disk. In particular, the
> > code containing the address of the memory block ("m->data + i * tda")
> > does /not/ respect the MULTIPLICITY!
>
> Thank you for the pleasantly thorough bug report and patch. I added
> some unit tests confirming the bug
> (http://bzr.savannah.gnu.org/lh/gsl/trunk/revision/4764) and applied
> your patch (http://bzr.savannah.gnu.org/lh/gsl/trunk/revision/4765).
> It repaired the problem without regressing any of the previously
> working real-valued cases. I missed the NEWS update in 4765 and added
> it in http://bzr.savannah.gnu.org/lh/gsl/trunk/revision/4766.
Thanks for the bug report and fixes.