RE: [Bug-gsl] Bug report with VC7

[Brian Gough]

Vincent Sacksteder writes:
 >      I'm not sure that I understand your response.  As I understand
 > it, _DLL should not be defined when compiling an exe.

Thanks for the clarification.  I don't know much about Windows and I
wasn't clear what the convention was for header files there.  I just
used _DLL because it seemed to work at the time.

If you can point me to any information on how the header files for
DLLs should look I'd be interested.  Here is what I have got for the
next release:

#ifdef WIN32
#  if defined(GSL_DLL)
#    ifdef DLL_EXPORT
#      define GSL_VAR extern __declspec(dllexport)
#    else
#      define GSL_VAR extern __declspec(dllimport)
#    endif
#  else
#    define GSL_VAR extern
#  endif
#else
#  define GSL_VAR extern
#endif

So the user needs to define GSL_DLL if they want to use the DLL with
dllimport (or to also define DLL_EXPORT while building the library).

 > As an aside, I am a little bit mixed up about why there are two
 > gsl_types.h files: GSL\include\gsl\gsl_types.h which is used by the
 > exe and GSL\src\gsl\gsl_types.h which is used by the dll.  At any
 > rate, the file I changed was GSL\include\gsl\gsl_types.h.

I'm following the way the library is built on Unix, with a separate
source and install directory.  For the end-user the src directory is
optional and can be deleted.

 > The warnings are still there though.  All but six are type
 > conversions.  Two were reports that gsl_sf_legendre_Plm_deriv_array
 > and gsl_sf_legendre_sphPlm_deriv_array might not return a value
 > under certain code paths.

This one is ok.

 > Also memcpy is reported as undefined when compiling cscal.c.

Thanks this is fixed in CVS.

 > And in coulomb.c G_lam_G and Gp_lam_G are used without having been
 > initialized.

I'll have to take another look at it.

 > There is also the following warning:
 > \Vincent\code\GSL\src\specfunc\legendre_poly.c(649) : warning
 > C4028: formal parameter 2 different from declaration

Thanks. Now fixed.

-- 
Brian Gough

----------------------------------------------------------------------
Network Theory Ltd           Phone: +44 117 3179309 (UK: 0117 3179309)
15 Royal Park                  Fax: +44 117 9048108 (UK: 0117 9048108)
Bristol BS8 3AL                WWW: http://www.network-theory.co.uk/
United Kingdom               Email: address@hidden     
----------------------------------------------------------------------