[bug #57889] grub-install no longer installs locales

[Martin Whitaker]

URL:
  <https://savannah.gnu.org/bugs/?57889>

                 Summary: grub-install no longer installs locales
                 Project: GNU GRUB
            Submitted by: martinwhitaker
            Submitted on: Mon 24 Feb 2020 11:00:17 PM UTC
                Category: Installation
                Severity: Major
                Priority: 5 - Normal
              Item Group: Software Error
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: 
                 Release: Git master
         Discussion Lock: Any
         Reproducibility: Every Time
         Planned Release: None

    _______________________________________________________

Details:

grub-install should install the specified (or, if not specified, all
available) locale files in the target directory. As of 2.04, it no longer does
this. This regression was introduced by

> commit 3d8439da8c9a4acf9bc1c41b364ec6e1680ef052
> Author: Olaf Hering <address@hidden>
> Date:   Fri Apr 13 23:36:49 2018 +0200
> 
>     grub-install: Locale depends on nls
>     
>     With --disable-nls no locales exist.

This commit surrounds the code that copies the locale files with the
condition

> #if !(defined (GRUB_UTIL) && defined(ENABLE_NLS) && ENABLE_NLS)

This condition is inverted, and should be

> #if (defined (GRUB_UTIL) && defined(ENABLE_NLS) && ENABLE_NLS)

The attached patch fixes the problem.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 24 Feb 2020 11:00:17 PM UTC  Name:
0001-grub-install-fix-inverted-test-for-NLS-enabled-when-.patch  Size: 1KiB  
By: martinwhitaker

<http://savannah.gnu.org/bugs/download.php?file_id=48494>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57889>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/