[bug #54841] grub-mkstandalone output is not reproducible

[Bernhard M.]

URL:
  <https://savannah.gnu.org/bugs/?54841>

                 Summary: grub-mkstandalone output is not reproducible
                 Project: GNU GRUB
            Submitted by: bmwiedemann
            Submitted on: Mon 15 Oct 2018 03:30:43 PM UTC
                Category: None
                Severity: Major
                Priority: 5 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 
                 Release: 2.02
         Reproducibility: None
         Planned Release: None

    _______________________________________________________

Details:

While working on reproducible builds for openSUSE, I found that
the grub2 package's grub.xen differed in every build.
It is generated by
./grub-mkstandalone --grub-mkimage=./grub-mkimage -o grub.xen -O x86_64-xen -d
grub-core/
/boot/grub/grub.cfg=/home/abuild/rpmbuild/SOURCES/grub2-xen-pv-firmware.cfg

which embeds mtimes of files and also uses indeterministic readdir order in
add_tar_file

The mtimes can be fixed with the attached patch.

Can POSIX scandir be used in that code?
That could solve the readdir issue.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 15 Oct 2018 03:30:43 PM UTC  Name: reproducible.patch  Size: 1KiB  
By: bmwiedemann

<http://savannah.gnu.org/bugs/download.php?file_id=45202>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?54841>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/