bug-grub
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Error in source code of GRUB2 module "grub-core/loader/i386/linux.c"


From: BURETTE, Bernard
Subject: Error in source code of GRUB2 module "grub-core/loader/i386/linux.c"
Date: Thu, 13 Sep 2012 14:59:26 +0200

Hi,
 
I downloaded the current source code for GRUB2 (version 2.00), and reading it I fell on :
------
#ifdef GRUB_MACHINE_EFI
#ifdef __x86_64__
  if (grub_le_to_cpu16 (params->version < 0x0208) &&
      ((grub_addr_t) grub_efi_system_table >> 32) != 0)
    return grub_error(GRUB_ERR_BAD_OS,
                      "kernel does not support 64-bit addressing");
#endif
------
starting at line 838 in file /grub-core/loader/i386/linux.c
 
This is obviously an error, I bet the test should read *** grub_le_to_cpu16 (params->version) < 0x0208 ***
Instead of *** grub_le_to_cpu16 (params->version < 0x0208) ***
 
But still I’m not sure what this test wants to achieve, it will deny loading a kernel implementing boot protocol 2.07 or less (so kernel 2.6.24 or less) if the EFI system tables address were beyond 4Gio, still I know there have been 2.4 kernels with 64 bits support (so should be able to access these tables), and I think EFI support was added around version 2.04 of the boot protocol.
 
Thank you anyway for reviewing this error, no answer requested.
 
Best regards.
 
______
Bernard Burette
Bouygtel / Systèmes d'information réseau / ISIS / Architecture et environnements de tests
 
 

  ________________________________  
L'intégrité de ce message n'étant pas assurée sur internet, la société expéditrice ne peut être tenue responsable de son contenu ni de ses pièces jointes. Toute utilisation ou diffusion non autorisée est interdite. Si vous n'êtes pas destinataire de ce message, merci de le détruire et d'avertir l'expéditeur.

The integrity of this message cannot be guaranteed on the Internet. The company that sent this message cannot therefore be held liable for its content nor attachments. Any unauthorized use or dissemination is prohibited. If you are not the intended recipient of this message, then please delete it and notify the sender.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]