bug-grub
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #32472] GRUB2 does not flush data correctly after installing


From: КоренбергМарк
Subject: [bug #32472] GRUB2 does not flush data correctly after installing
Date: Sun, 10 Apr 2011 16:27:31 +0000
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US) AppleWebKit/534.16 (KHTML, like Gecko) Ubuntu/10.10 Chromium/10.0.648.133 Chrome/10.0.648.133 Safari/534.16

Follow-up Comment #9, bug #32472 (project grub):

open_device():
If we use fsync() before close(), 

O_SYNC, O_FSYNC should not be used, as it give performance penalty.

When O_SYNC used, every write is blocked  until it goes to disk, and fsync()
does nothing.

When O_SYNC is not used, every write is not blocked, but all modified blocks
are written inside fsync(). During fsync(), blocks may be merged, so not using
O_SYNC may significantly improve performance.

So, see attached patch


(file #23191)
    _______________________________________________________

Additional Item Attachment:

File name: z.patch                        Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?32472>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]