Re: Grub Failure when HDD descriptor changes

[Molle Bestefich]

Yoshinori K. Okuji wrote:
>> * lib/device.c (get_drive_geometry):
>> Shuffle BLKGETSIZE and HD_GETGEO so that a correct sector count can
>> be retrieved for device-mapper devices in the stage2 simulator.
> 
> You should be more explicit. Instead of saying just "shuffle", mention how you
> changed the code, like "first, do this, and if it fails, do that".

How 'bout this:

* lib/device.c (get_drive_geometry):
Attempt BLKGETSIZE even if HD_GETGEO fails by calling it first, so
that a correct sector count can be retrieved for device-mapper devices
in the stage2 simulator.

> The code itself looks good, except for the coding style. The positions of
> braces are not good. Once you correct it, I will apply it.

Sure?
I actually took some care to avoid unnecessary +'s and -'s in the diff.

If I were to indent the code correctly, you would end up with a patch
that was harder to read, since indentations would have to be adjusted
due to scope changes..

Do you want me to correct tab/spaces into something uniform? (I prefer
tabs myself)