[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug#268482: Please include reiser4 fs support

From: Robert Millan
Subject: Re: Bug#268482: Please include reiser4 fs support
Date: Tue, 21 Sep 2004 19:16:02 +0200
User-agent: Mutt/1.5.6+20040722i

On Tue, Sep 21, 2004 at 11:55:24AM +0400, Vitaly Fertman wrote:
> > >  - The patch modifies stage2/ufs2.h, which has nothing to do with
> > > reiserfs. Your changes to ufs2.h look like portability improvements.  Is
> > > that it?
> yes, there were some problems with compiling. Grub with reiser4 support
> links to libreiser4 and libaal, to make it successfully compiled --nostdinc 
> option was eliminated and then ufs2 code started producing redefinition 
> errors. So I embraced such defines with ifndefs. 
> Would you prefere to solve it in another way?

IMHO, linking with an external library sounds right but nuking -nostdinc for
all the code doesn't.  I think that decision belongs to Okuji, the maintainer.

Okuji, I got this patch [1] from Debian BTS.  The copyright header says it
was written by Hans Reiser, but Hans says he didn't write it, and he hasn't
assigned copyright either.

Hans, if you know who wrote the patch please tell Okuji about it.  Thanks!

[1] ftp://ftp.namesys.com/pub/reiser4progs/grub/

 .''`.   Proudly running Debian GNU/kFreeBSD unstable/unreleased (on UFS2+S)
: :' :
`. `'    http://www.debian.org/ports/kfreebsd-gnu

reply via email to

[Prev in Thread] Current Thread [Next in Thread]